joywayerandClaude Opus 5
e1f67dde1c
问题：\`||\` 运算符接受任何 falsy 值（undefined/NaN/null）为帧 1， 违反「零兜底」原则。brief 仅明确规定 frameIndex=0 视同 1。 修法： - 将 \`frameIndex || 1\` 改为 \`frameIndex === 0 ? 1 : frameIndex\` - 在 frameRect 中加入 Number.isInteger 检查（拦截 NaN、undefined） - frameFileName 亦加验证，防止非法输入产出垃圾文件名 - 错误信息明确说明有效范围与 0→1 转换规则 新增 4 条测试用例覆盖 undefined 与 NaN，确保非整数被正确拒绝。 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
89 lines
3.7 KiB
JavaScript
89 lines
3.7 KiB
JavaScript
import { test } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { frameRect, padWidth, frameFileName, frameNames } from '../ui-migration/frames.mjs';
|
|
|
|
// 实测样例：00014.png 450x280，网格 3x4，单帧 150x70
|
|
const IMG_00014 = { id: 14, w_all: 450, h_all: 280, w: 3, h: 4, frame_all: 12, bmp: '00014.png', w1: 150, h1: 70 };
|
|
// 13 列 1 行
|
|
const IMG_00019 = { id: 19, w_all: 221, h_all: 28, w: 13, h: 1, frame_all: 13, bmp: '00019.png', w1: 17, h1: 28 };
|
|
const IMG_SINGLE = { id: 1, w_all: 1280, h_all: 720, w: 1, h: 1, frame_all: 1, bmp: '00001.png', w1: 1280, h1: 720 };
|
|
|
|
test('frameRect 帧 1 是左上角（1 基）', () => {
|
|
assert.deepEqual(frameRect(IMG_00014, 1), { x: 0, y: 0, width: 150, height: 70 });
|
|
});
|
|
|
|
test('frameRect 行优先：帧 4 换到第二行首列', () => {
|
|
// idx=3 → col = 3%3 = 0, row = 1
|
|
assert.deepEqual(frameRect(IMG_00014, 4), { x: 0, y: 70, width: 150, height: 70 });
|
|
});
|
|
|
|
test('frameRect 实证样例：「通知」FrameIndex=10 → 第 3 行第 0 列', () => {
|
|
// 已由读图验证：00014.png 第 3 行第 0 列即「通知」
|
|
assert.deepEqual(frameRect(IMG_00014, 10), { x: 0, y: 210, width: 150, height: 70 });
|
|
});
|
|
|
|
test('frameRect 实证样例：「设置」FrameIndex=11 → 第 3 行第 1 列', () => {
|
|
assert.deepEqual(frameRect(IMG_00014, 11), { x: 150, y: 210, width: 150, height: 70 });
|
|
});
|
|
|
|
test('frameRect 实证样例：「战绩」FrameIndex=4 → 第 1 行第 0 列', () => {
|
|
assert.deepEqual(frameRect(IMG_00014, 4), { x: 0, y: 70, width: 150, height: 70 });
|
|
});
|
|
|
|
test('frameRect 单行网格逐列推进', () => {
|
|
assert.deepEqual(frameRect(IMG_00019, 1), { x: 0, y: 0, width: 17, height: 28 });
|
|
assert.deepEqual(frameRect(IMG_00019, 13), { x: 204, y: 0, width: 17, height: 28 });
|
|
});
|
|
|
|
test('frameRect FrameIndex=0 按帧 1 处理', () => {
|
|
assert.deepEqual(frameRect(IMG_00014, 0), frameRect(IMG_00014, 1));
|
|
});
|
|
|
|
test('frameRect 越界抛 RangeError 且带图名', () => {
|
|
assert.throws(() => frameRect(IMG_00014, 13), RangeError);
|
|
assert.throws(() => frameRect(IMG_00014, 13), /00014\.png/);
|
|
});
|
|
|
|
test('frameRect undefined 作为 frameIndex 抛 RangeError', () => {
|
|
assert.throws(() => frameRect(IMG_00014, undefined), RangeError);
|
|
assert.throws(() => frameRect(IMG_00014, undefined), /00014\.png/);
|
|
});
|
|
|
|
test('frameRect NaN 作为 frameIndex 抛 RangeError', () => {
|
|
assert.throws(() => frameRect(IMG_00014, NaN), RangeError);
|
|
assert.throws(() => frameRect(IMG_00014, NaN), /00014\.png/);
|
|
});
|
|
|
|
test('padWidth 按帧总数决定补零位数', () => {
|
|
assert.equal(padWidth(9), 1);
|
|
assert.equal(padWidth(12), 2);
|
|
assert.equal(padWidth(100), 3);
|
|
});
|
|
|
|
test('frameFileName 1 基且补零，保证字典序等于帧序', () => {
|
|
assert.equal(frameFileName('00014.png', 1, 12), '00014_01.png');
|
|
assert.equal(frameFileName('00014.png', 10, 12), '00014_10.png');
|
|
const names = [frameFileName('00014.png', 2, 12), frameFileName('00014.png', 10, 12)];
|
|
assert.deepEqual([...names].sort(), ['00014_02.png', '00014_10.png'], '字典序必须等于帧序');
|
|
});
|
|
|
|
test('frameFileName 单帧图原样返回', () => {
|
|
assert.equal(frameFileName('00001.png', 1, 1), '00001.png');
|
|
});
|
|
|
|
test('frameFileName undefined 作为 frameIndex 抛 RangeError', () => {
|
|
assert.throws(() => frameFileName('00014.png', undefined, 12), RangeError);
|
|
});
|
|
|
|
test('frameFileName NaN 作为 frameIndex 抛 RangeError', () => {
|
|
assert.throws(() => frameFileName('00014.png', NaN, 12), RangeError);
|
|
});
|
|
|
|
test('frameNames 返回全部帧，下标 0 对应帧 1', () => {
|
|
const names = frameNames(IMG_00014);
|
|
assert.equal(names.length, 12);
|
|
assert.equal(names[0], '00014_01.png');
|
|
assert.equal(names[11], '00014_12.png');
|
|
assert.deepEqual(frameNames(IMG_SINGLE), ['00001.png']);
|
|
});
|