fix(net): validate wire frames and coalesce reconnects

2026-09-05 04:25:51 +08:00
parent 58a7a2dc68
commit 85db7765ac
3 changed files with 272 additions and 22 deletions
@@ -159,6 +159,8 @@ test('send rejects malformed completed envelopes before touching transport', asy
    { app: 'youle', route: '', rpc: 'x', data: {} },
    { app: 'youle', route: 'agent', rpc: '', data: {} },
    { app: 'youle', route: 'agent', rpc: 'x' },
+    { app: 'youle', route: 'agent', rpc: 'x', data: {}, extra: true },
+    { app: 'youle', route: 'agent', rpc: 'x', data: () => 1 },
    null,
  ];
  for (const value of invalid) {
@@ -167,6 +169,101 @@ test('send rejects malformed completed envelopes before touching transport', asy
  assert.deepEqual(transport.sent, []);
 });

+test('send accepts the complete protocol JSON value boundary without rebuilding bytes', async () => {
+  const { client, transports } = makeHarness();
+  client.start();
+  const transport = transports[0]!;
+  await transport.flush();
+  const nullPrototype = Object.assign(Object.create(null) as Record<string, unknown>, {
+    nested: [null, 'text', true, false, 0, -1.5],
+  });
+  const valid = {
+    rpc: 'json_boundary',
+    data: nullPrototype,
+    route: 'agent',
+    app: 'youle',
+  } as OutboundEnvelope;
+
+  client.send(valid);
+
+  assert.equal(transport.sent[0], JSON.stringify(valid));
+});
+
+test('send rejects every non-JSON data graph edge with its exact path', async () => {
+  const { client, transports } = makeHarness();
+  client.start();
+  const transport = transports[0]!;
+  await transport.flush();
+
+  const sparse: unknown[] = [];
+  sparse.length = 1;
+  const arrayWithExtra = [] as unknown[] & { extra?: number };
+  arrayWithExtra.extra = 1;
+  const cyclic: Record<string, unknown> = {};
+  cyclic.self = cyclic;
+  const withAccessor: Record<string, unknown> = {};
+  let getterCalls = 0;
+  Object.defineProperty(withAccessor, 'secret', {
+    enumerable: true,
+    get() { getterCalls++; return 1; },
+  });
+  const withHidden: Record<string, unknown> = {};
+  Object.defineProperty(withHidden, 'hidden', { enumerable: false, value: 1 });
+  const withSymbolKey: Record<PropertyKey, unknown> = { visible: true };
+  withSymbolKey[Symbol('hidden')] = 1;
+  class Exotic { value = 1; }
+
+  const cases: ReadonlyArray<readonly [unknown, RegExp]> = [
+    [{ value: undefined }, /\$\.data\.value.*undefined/i],
+    [{ value: () => 1 }, /\$\.data\.value.*function/i],
+    [{ value: Symbol('x') }, /\$\.data\.value.*symbol/i],
+    [{ value: 1n }, /\$\.data\.value.*bigint/i],
+    [{ value: Number.NaN }, /\$\.data\.value.*finite number/i],
+    [{ value: Number.POSITIVE_INFINITY }, /\$\.data\.value.*finite number/i],
+    [{ nested: sparse }, /\$\.data\.nested\[0\].*array hole/i],
+    [{ nested: arrayWithExtra }, /\$\.data\.nested\.extra.*extra array property/i],
+    [{ nested: new Date(0) }, /\$\.data\.nested.*plain object/i],
+    [{ nested: new Exotic() }, /\$\.data\.nested.*plain object/i],
+    [{ nested: withAccessor }, /\$\.data\.nested\.secret.*accessor/i],
+    [{ nested: withHidden }, /\$\.data\.nested\.hidden.*enumerable/i],
+    [{ nested: withSymbolKey }, /\$\.data\.nested.*symbol key/i],
+    [{ nested: { toJSON: () => ({ changed: true }) } }, /\$\.data\.nested\.toJSON.*function/i],
+    [cyclic, /\$\.data\.self.*cycle/i],
+  ];
+  for (const [data, expected] of cases) {
+    assert.throws(
+      () => client.send({ app: 'youle', route: 'agent', rpc: 'x', data }),
+      expected,
+    );
+  }
+  assert.equal(getterCalls, 0, 'accessor validation must not invoke the getter');
+  assert.deepEqual(transport.sent, []);
+});
+
+test('send rejects top-level symbol, non-enumerable and accessor properties', async () => {
+  const { client, transports } = makeHarness();
+  client.start();
+  const transport = transports[0]!;
+  await transport.flush();
+
+  const symbolEnvelope = { app: 'youle', route: 'agent', rpc: 'x', data: {} };
+  Object.defineProperty(symbolEnvelope, Symbol('extra'), { enumerable: true, value: 1 });
+  const hiddenEnvelope = { app: 'youle', route: 'agent', rpc: 'x' } as Record<string, unknown>;
+  Object.defineProperty(hiddenEnvelope, 'data', { enumerable: false, value: {} });
+  let accessorCalls = 0;
+  const accessorEnvelope = { app: 'youle', route: 'agent', rpc: 'x' } as Record<string, unknown>;
+  Object.defineProperty(accessorEnvelope, 'data', {
+    enumerable: true,
+    get() { accessorCalls++; return {}; },
+  });
+
+  assert.throws(() => client.send(symbolEnvelope as OutboundEnvelope), /top-level.*symbol/i);
+  assert.throws(() => client.send(hiddenEnvelope as unknown as OutboundEnvelope), /\$\.data.*enumerable/i);
+  assert.throws(() => client.send(accessorEnvelope as unknown as OutboundEnvelope), /\$\.data.*accessor/i);
+  assert.equal(accessorCalls, 0);
+  assert.deepEqual(transport.sent, []);
+});
+
 test('constructor rejects an empty validated server list and start cannot run twice', () => {
  assert.throws(
    () => new WireClient({ servers: [], transportFactory: () => new FakeTransport() }),
@@ -304,6 +401,35 @@ test('a reconnecting listener can stop without leaving a timer or reviving a cle
  assert.equal(transports.length, 1);
 });

+test('reconnectCurrent coalesces the same pending target before reconnecting listeners run', async () => {
+  const { client, transports, advance, activeTimers } = makeHarness();
+  let reconnectEvents = 0;
+  let reentered = false;
+  const timerCountsDuringEvent: number[] = [];
+  client.subscribe((event) => {
+    if (event.type !== 'reconnecting') return;
+    reconnectEvents++;
+    timerCountsDuringEvent.push(activeTimers());
+    if (!reentered) {
+      reentered = true;
+      client.reconnectCurrent();
+    }
+  });
+  client.start();
+  const first = transports[0]!;
+  await first.flush();
+  first.serverClose();
+  await first.flush();
+
+  client.reconnectCurrent();
+  assert.equal(reconnectEvents, 1);
+  assert.deepEqual(timerCountsDuringEvent, [1]);
+  assert.equal(activeTimers(), 1);
+  advance(10000);
+  assert.equal(transports.length, 2);
+  assert.equal(transports[1]!.url, 'ws://a');
+});
+
 test('slow listener stop prevents the timeout path from scheduling reconnect', async () => {
  const { client, transports, advance, activeTimers } = makeHarness();
  client.subscribe((event) => {
@@ -431,6 +557,33 @@ test('transport connect synchronous failure ignores duplicate close/error and co
  assert.equal(recovered.url, 'ws://a');
 });

+test('FakeTransport and WireClient preserve synchronous throw null as one connection failure', async () => {
+  const timer = fakeClock();
+  const broken = new FakeTransport();
+  broken.failNextConnect(null);
+  const recovered = new FakeTransport();
+  const transports = [broken, recovered];
+  let factoryIndex = 0;
+  const events: WireEvent[] = [];
+  const client = new WireClient({
+    servers: ['ws://a'],
+    clock: timer.clock,
+    transportFactory: () => transports[factoryIndex++]!,
+  });
+  client.subscribe((event) => events.push(event));
+
+  client.start();
+  assert.deepEqual(events, [
+    { type: 'close' },
+    { type: 'reconnecting', server: 'ws://a' },
+  ]);
+  assert.equal(broken.closeCalls, 1);
+  assert.equal(timer.activeTimers(), 1);
+  timer.advance(10000);
+  await recovered.flush();
+  assert.deepEqual(events[events.length - 1], { type: 'open', server: 'ws://a' });
+});
+
 test('stale transport generations cannot emit messages or opens', async () => {
  const { client, transports, advance } = makeHarness();
  const events: WireEvent[] = [];