basegames/zeling_v2
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add independent review reports for Minimap system (Rounds 8, 9, and 26)

Browse Source 
- Round 8 report highlights improvements in architecture, editor usability, and data robustness, with a total score of 80/100.
- Round 9 report focuses on editor extension capabilities, identifying issues with room data indexing and layout editing, resulting in a score of 76/100.
- Round 26 report evaluates the system against commercial standards, noting new issues and confirming previous fixes, with a score of 95.8/100.
This commit is contained in:
Joywayer
2026-05-25 23:15:12 +08:00
parent e2bc324905
commit f74d7f1877
53 changed files with 6825 additions and 270 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
Assets/_Game/Scripts/World/Map/MapManager.cs
View File

@@ -1,3 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;
using UnityEngine;
@@ -19,7 +20,8 @@ namespace BaseGames.World.Map
[Header("Event Channels")]
[SerializeField] private StringEventChannelSO _onRoomEntered; // 订阅 EVT_RoomEntered
[SerializeField] private StringEventChannelSO _onMapUpdated; // 发布：房间发现时
[Tooltip("房间被探索/标记时广播（Explored/Mapped）；地图 UI 已改用 C# 事件，此通道保留供地图外部系统订阅（如成就、音效）。")]
[SerializeField] private StringEventChannelSO _onMapUpdated; // 发布：房间发现时（地图 UI 内当前无订阅者）
[SerializeField] private StringEventChannelSO _onRegionChanged; // 发布：玩家首次进入新区域时（EVT_RegionChanged）
// 三级可见性：
@@ -30,22 +32,26 @@ namespace BaseGames.World.Map
private HashSet<string> _mappedRooms = new();
private string _currentRegionId;
private int _totalRoomCount = -1; // -1 = 未缓存；OnLoad 后重置
private Dictionary<string, MapRoomDataSO[]> _regionCache; // R11-N6 GetRoomsByRegion 结果缓存
private bool _isDuplicate; // Awake 检测到重复实例时置位，OnEnable/OnDisable 提前 return
private readonly CompositeDisposable _subs = new();
private void Awake()
{
if (ServiceLocator.GetOrDefault<IMapService>() != null) { Destroy(gameObject); return; }
if (ServiceLocator.GetOrDefault<IMapService>() != null) { _isDuplicate = true; Destroy(gameObject); return; }
ServiceLocator.Register<IMapService>(this);
}
private void OnEnable()
{
if (_isDuplicate) return;
_onRoomEntered?.Subscribe(OnRoomEntered).AddTo(_subs);
ServiceLocator.GetOrDefault<ISaveableRegistry>()?.Register(this);
}
private void OnDisable()
{
if (_isDuplicate) return;
_subs.Clear();
ServiceLocator.GetOrDefault<ISaveableRegistry>()?.Unregister(this);
}
@@ -56,21 +62,31 @@ namespace BaseGames.World.Map
{
data.Map.ExploredRooms = new HashSet<string>(_exploredRooms);
data.Map.MappedRooms = new HashSet<string>(_mappedRooms);
data.Map.LastRegionId = _currentRegionId;
}
public void OnLoad(SaveData data)
{
_exploredRooms = data.Map.ExploredRooms != null ? new HashSet<string>(data.Map.ExploredRooms) : new HashSet<string>();
_mappedRooms = data.Map.MappedRooms != null ? new HashSet<string>(data.Map.MappedRooms) : new HashSet<string>();
_totalRoomCount = -1; // 强制下次调用 GetExplorationProgress 时重新计数
_exploredRooms = data.Map.ExploredRooms != null ? new HashSet<string>(data.Map.ExploredRooms) : new HashSet<string>();
_mappedRooms = data.Map.MappedRooms != null ? new HashSet<string>(data.Map.MappedRooms) : new HashSet<string>();
_currentRegionId = data.Map.LastRegionId; // 恢复区域 ID，避免读档后首次进房误触发 EVT_RegionChanged
_totalRoomCount = -1; // 强制下次调用 GetExplorationProgress 时重新计数
// 读档后广播：UI 仅需轻量刷新（不重建结构）；订阅 OnExplorationChanged 的 UI 会 RefreshAllCells
OnExplorationChanged?.Invoke();
}
// ── 事件驱动房间发现 ──────────────────────────────────────────────────
private void OnRoomEntered(string roomId)
{
if (string.IsNullOrEmpty(roomId)) return;
bool changed = _exploredRooms.Add(roomId);
if (changed) _onMapUpdated?.Raise(roomId);
if (changed)
{
_onMapUpdated?.Raise(roomId);
OnExplorationChanged?.Invoke();
}
// 区域变化检测：RegionId 非空且与上一次不同时广播 EVT_RegionChanged
var regionId = _database?.GetRoom(roomId)?.RegionId;
@@ -88,8 +104,31 @@ namespace BaseGames.World.Map
/// </summary>
public void SetMapped(string roomId)
{
if (string.IsNullOrEmpty(roomId)) return;
if (_mappedRooms.Add(roomId))
{
_onMapUpdated?.Raise(roomId);
OnRoomMapped?.Invoke(roomId);
OnExplorationChanged?.Invoke();
}
}
/// <inheritdoc/>
public void SetMappedBatch(IEnumerable<string> roomIds)
{
if (roomIds == null) return;
bool anyAdded = false;
foreach (var roomId in roomIds)
{
if (string.IsNullOrEmpty(roomId)) continue;
if (_mappedRooms.Add(roomId))
{
_onMapUpdated?.Raise(roomId);
OnRoomMapped?.Invoke(roomId);
anyAdded = true;
}
}
if (anyAdded) OnExplorationChanged?.Invoke();
}
// ── 查询 API ──────────────────────────────────────────────────────────
@@ -112,11 +151,40 @@ namespace BaseGames.World.Map
{
if (string.IsNullOrEmpty(regionId) || _database?.AllRooms == null)
return System.Array.Empty<MapRoomDataSO>();
return _database.AllRooms.Where(r => r != null && r.RegionId == regionId).ToArray();
// R11-N6 懒加载缓存，避免每帧 LINQ 扫描全量房间数组
_regionCache ??= new Dictionary<string, MapRoomDataSO[]>();
if (!_regionCache.TryGetValue(regionId, out var cached))
{
cached = _database.AllRooms.Where(r => r != null && r.RegionId == regionId).ToArray();
_regionCache[regionId] = cached;
}
return cached;
}
// ── 数据库热更事件 ────────────────────────────────────────────────────
/// <inheritdoc/>
public event Action OnDatabaseChanged;
/// <inheritdoc/>
public event Action OnExplorationChanged;
/// <inheritdoc/>
public event Action<string> OnRoomMapped;
/// <inheritdoc/>
public void NotifyDatabaseChanged()
{
_database?.InvalidateIndex();
_totalRoomCount = -1;
_regionCache = null; // R11-N6 数据库变更时清空区域缓存
OnDatabaseChanged?.Invoke();
}
private void OnDestroy()
{
if (_isDuplicate) return;
ServiceLocator.Unregister<IMapService>(this);
}
}